fixed library extension to build properly under CYGWIN#1788
Closed
Smartsmurf wants to merge 4 commits intocapstone-engine:masterfrom
Smartsmurf:master
Closed
fixed library extension to build properly under CYGWIN#1788Smartsmurf wants to merge 4 commits intocapstone-engine:masterfrom Smartsmurf:master
Smartsmurf wants to merge 4 commits intocapstone-engine:masterfrom
Smartsmurf:master
Conversation
Member
|
@Smartsmurf thanks for PR, looks like CIFuzz is failed, can you fix this? and plz rebase to dev branch |
Member
|
Don't forget to rebase to dev branch, thank you |
Contributor
Author
|
@kabeor fixed CIFuzz and rebased against master branch. |
Member
capstone-engine only accept PR for dev branch, now you are in master branch, change it to dev plz. |
Contributor
Author
|
OK, what is dev branch? the one named "next"? |
Member
|
oh, my fault, yes, 'next' branch |
Member
|
move to #1791, close this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently capstone fails to build under CYGWIN although it seems supported.
Please find attached the pull request to fix that (instead of "capstone." it now uses "capstone.lib" / "capstone.dll").